Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update goreleaser to v1.2.4 in build image #1168

Merged
merged 7 commits into from
Jan 4, 2022
Merged

Update goreleaser to v1.2.4 in build image #1168

merged 7 commits into from
Jan 4, 2022

Conversation

akankshakumari393
Copy link
Contributor

@akankshakumari393 akankshakumari393 commented Dec 31, 2021 •
edited
Loading

Change Overview

  • Use goreleaser version 1.2.4
  • update build image to version ghcr.io/kanisterio/build:v0.0.15
  • Update binaries field in goreleaser.yml as ids
  • Use semantic version tag v9.99.9-dev instead of latest
  • Add Make target build- controller to build controller binary

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E
    Pushed build image with tag ghcr.io/kanisterio/build:v0.0.15 and respective application images manually with tag v9.99.9-dev

viveksinghggits
viveksinghggits reviewed Jan 3, 2022
View reviewed changes
.goreleaser.yml Outdated Show resolved Hide resolved
PrasadG193
PrasadG193 reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mergify mergify bot merged commit 24689ac into master Jan 4, 2022
@mergify mergify bot deleted the update_goreleaser branch January 4, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

@onkarbhat onkarbhat Awaiting requested review from onkarbhat

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akankshakumari393 @PrasadG193 @viveksinghggits